• src/sbbs3/sbbs_ini.c

    From rswindell@1:103/705 to CVS commit on Fri Mar 9 16:01:50 2018
    src/sbbs3 sbbs_ini.c 1.162 1.163
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv3310

    Modified Files:
    sbbs_ini.c
    Log Message:
    Fix some potential NULL dereferences in sbbs_write_ini() (if 'bbs' arg was passsed as NULL) found by scan-build.

    --- SBBSecho 3.03-Win32
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From rswindell@1:103/705 to CVS commit on Sat Jan 12 16:37:58 2019
    src/sbbs3 sbbs_ini.c 1.166 1.167
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv27318

    Modified Files:
    sbbs_ini.c
    Log Message:
    Updated the default sbbs.ini style when saving (improve readability):
    - separate sections with a blank line (when adding a section)
    - place spaces around '=' in value assignments ("key = value").

    --- SBBSecho 3.06-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From rswindell@1:103/705 to CVS commit on Sun Jan 13 14:05:45 2019
    src/sbbs3 sbbs_ini.c 1.167 1.168
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv21518

    Modified Files:
    sbbs_ini.c
    Log Message:
    We build this file with BCB6, which is not C99 compliant, so we can't use this fancy structure initalization syntax here.

    --- SBBSecho 3.06-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From rswindell@1:103/705 to CVS commit on Sun Mar 24 00:11:48 2019
    src/sbbs3 sbbs_ini.c 1.168 1.169
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv10862

    Modified Files:
    sbbs_ini.c
    Log Message:
    Rename the 2 outbound interface keys that were introduced by Deuce in the big IPv6 commit of 2015:
    "OutgoingV4" is now "OutboundInterface" and
    "OutgoingV6" is now "OutboundV6Interface" (which is not yet used)


    --- SBBSecho 3.07-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Deucе@1:103/705 to Git commit to main/sbbs/master on Mon Mar 15 01:50:34 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/3088251b238e609e78512774
    Modified Files:
    src/sbbs3/sbbs_ini.c
    Log Message:
    DOSCmd is only on FreeBSD and DOSEmu is only on Linux.Do not get/set these values on other OSs. Fixes a segfault causedby default_dosemuconf_path being undefined on FreeBSD, but wouldalso happen on any other *nix platform (ie: OpenBSD, etc).
    --- SBBSecho 3.13-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Sat Apr 17 15:19:19 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/ed1d83733aed40bf68ab8e03
    Modified Files:
    src/sbbs3/sbbs_ini.c
    Log Message:
    Fix typo in previous commit.
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Sat Apr 17 21:23:39 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/53601146c3c5240cf71b3559
    Modified Files:
    src/sbbs3/sbbs_ini.c
    Log Message:
    Write the global sound (WAV) file settings in sbbs_write_ini().
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Tue May 4 22:17:59 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/97650f46f31d299e3825ee77
    Modified Files:
    src/sbbs3/sbbs_ini.c
    Log Message:
    sbbs_write_ini() called with a NULL global pointer could have crashedas get_ini_globals() will de-ref the 'interfaces' element. CID 331352
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Mon Jan 17 18:56:26 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/7effd1d98ce808c6c0a6f9e3
    Modified Files:
    src/sbbs3/sbbs_ini.c
    Log Message:
    Fix problem saving HangupSound setting in sbbs.iniApparent copy/paste error in sbbs_set_sound_settings() - I was wondering why the HangupSound key wasn't saving to the sbbs.ini file from SBBSCTRL.
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (in GitKraken)@1:103/705 to Git commit to main/sbbs/master on Sun Mar 12 00:00:02 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/5b7c88d7a406aef0c80eeab9
    Modified Files:
    src/sbbs3/sbbs_ini.c
    Log Message:
    Remove extraneous ulong typedef
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (in GitKraken)@1:103/705 to Git commit to main/sbbs/master on Sun Mar 12 17:42:56 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/2b087aaabfa8dcc80bcafa92
    Modified Files:
    src/sbbs3/sbbs_ini.c
    Log Message:
    Add back a (different) typecast to eliminate MSVC warning
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows)@1:103/705 to Git commit to main/sbbs/master on Mon Apr 3 23:16:10 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/f95f67ac43c455993a84f03d
    Modified Files:
    src/sbbs3/sbbs_ini.c
    Log Message:
    Fix double-free race condition with SBBSCTRL upon global recycleWhen multiple servers are recycling at the same time, (e.g. due to savedchange in SCFG) they'd each call sbbs_read_ini() with a shared global_startupstruct, which in turn calls sbbs_free_ini(), which would free all theallocated network interface
    lists (including the global_startup one) usinginiFreeStringList (just a wrapper
    for strListFree), but iniFreeStringList()does NOT modify (NULLify) the freed-pointer, so your second or third serverthat called sbbs_read_ini(), with the shared MainForm->global structure, would*again* free the same global interface list. This bug actually has alwaysexisted because get_ini_globals() freed the global interface list in the sameway, except it *immediately* re-allocated a new one by callinginiGetStringList(), so the time window (opportunity) for this race conditionto occur was much smaller. Truly, SBBSCTRL
    should use a mutex or othermechanism to protect the shared global_startup struct, but this is a firststep to a full fix: sbbs_free_ini() should (and now does) nullify the freednetwork interface pointers by using strListFree() directly. I haven't beenable to reproduce the crash upon recycle in SBBSCTRL after making this change.
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Randy Sommerfeld@1:103/705 to Git commit to main/sbbs/master on Tue Apr 4 02:04:36 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/fcf4a00126190ded4fc11a1c
    Modified Files:
    src/sbbs3/sbbs_ini.c
    Log Message:
    Merge branch 'master' of gitlab.synchro.net:main/sbbs
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows)@1:103/705 to Git commit to main/sbbs/master on Mon May 1 12:00:24 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/b8d4452d1e5cb7a0b586e07f
    Modified Files:
    src/sbbs3/sbbs_ini.c
    Log Message:
    Fix valgrind-reported memleak in sbbs_read_ini()
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows 11)@1:103/705 to Git commit to main/sbbs/master on Tue Dec 19 22:13:27 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/516a01a6e1949837f7acbb8f
    Modified Files:
    src/sbbs3/sbbs_ini.c
    Log Message:
    Support durations (e.g. "2m") syntax for timeout settings

    Interestingly, qwk_timeout was already read (but not set) as a duration.

    Add "NO_CGI" to the default Web Server options.
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows 11)@1:103/705 to Git commit to main/sbbs/master on Wed Dec 27 00:42:02 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/b1875c4bf34a736631517368
    Modified Files:
    src/sbbs3/sbbs_ini.c
    Log Message:
    Read/write "Frequency" (actually, interval) key values as durations

    This fixes the issue reported by Nelgin with the [mail] RescanFrequency new default value of "1h" being interpretted as one second intead of one hour.
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)