• src/sbbs3/load_cfg.c

    From rswindell@1:103/705 to CVS commit on Tue Mar 6 16:57:02 2018
    src/sbbs3 load_cfg.c 1.72 1.73
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv5267

    Modified Files:
    load_cfg.c
    Log Message:
    Change for Nelgin:
    If the sysop does not specify a file transfer path for a directory, but
    did specify a custom data directory, use the custom data directory as the parent of the auto-generated sub-directory to use for the file storage
    path. If this breaks existing configs (are you files are offline?), sorry.


    --- SBBSecho 3.03-Win32
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From rswindell@1:103/705 to CVS commit on Sat Jul 28 17:26:16 2018
    src/sbbs3 load_cfg.c 1.73 1.74
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv12120

    Modified Files:
    load_cfg.c
    Log Message:
    Remove dots (.) from internal codes auto-generated from other strings.


    --- SBBSecho 3.05-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From rswindell@1:103/705 to CVS commit on Thu Oct 18 14:28:23 2018
    src/sbbs3 load_cfg.c 1.74 1.75
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv25449

    Modified Files:
    load_cfg.c
    Log Message:
    Log the errno description text along with the number when failing to
    create a directory.


    --- SBBSecho 3.06-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From rswindell@1:103/705 to CVS commit on Mon Aug 5 18:51:40 2019
    src/sbbs3 load_cfg.c 1.76 1.77
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv23213

    Modified Files:
    load_cfg.c
    Log Message:
    A more sensible (though not 100% backwards compatiblity) Transfer File Path default-setting.
    - If a directory's Transfer File Path is not set (blank), and the library
    has a "parent directory" configured, then the default Transfer File Path
    will (now) be <parent>/<dir-code>, where <dir-code> is the directory's
    internal code (lower-cased). This is different from previous behavior where
    the parent dir was not used unless *something* was entered for a dir's
    Transfer File Path. I'm sorry if this brakes your b0rad!
    - If a directory's Transfer File Path is not set (blank), and the library does
    *not* hae a "parent directory" configured, then the behavior should be the
    same as before, default Transfer File Path: <data-dir>/<dir-code>
    - If a directory's Transfer File Path is already set to a
    full path, there should be no change in behavior either.


    --- SBBSecho 3.08-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From rswindell@1:103/705 to CVS commit on Mon Aug 5 20:08:47 2019
    src/sbbs3 load_cfg.c 1.77 1.78
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv647

    Modified Files:
    load_cfg.c
    Log Message:
    Fix typo in previous commit.


    --- SBBSecho 3.08-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From rswindell@1:103/705 to CVS commit on Mon Aug 5 21:38:51 2019
    src/sbbs3 load_cfg.c 1.78 1.79
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv11280

    Modified Files:
    load_cfg.c
    Log Message:
    When the LIB_DIRS option is enabled (auto-add sub-directories of teh parent directory), ignore dirs that are already configured, i.e. internal code
    suffix matches the sub-dir name.


    --- SBBSecho 3.08-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From rswindell@1:103/705 to CVS commit on Tue Aug 6 00:40:06 2019
    src/sbbs3 load_cfg.c 1.79 1.80
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv2664

    Modified Files:
    load_cfg.c
    Log Message:
    Remove trailing slash from sub-dir name before comparing against internal
    code. Compare against full internal-code (not just suffix) for duplicate detection.


    --- SBBSecho 3.08-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From rswindell@1:103/705 to CVS commit on Mon May 25 18:49:22 2020
    src/sbbs3 load_cfg.c 1.81 1.82
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/home/rswindell/sbbs/src/sbbs3

    Modified Files:
    load_cfg.c
    Log Message:
    Address gcc warnings about string buffer overflows, like this one:
    warning: ΓÇÿsubsΓÇÖ directive writing 4 bytes into a region of size between 1 and 64


    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Thu Jan 21 01:44:24 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/9439f5b8e23351f3a96982b0
    Modified Files:
    src/sbbs3/load_cfg.c
    Log Message:
    Fix: initialize default data directories after auto-creating sub-dirsWhen a file library's "Access to Sub-directories" option was enabled, any auto-created
    directories would have their data dir initialized as "blank" (empty), so their data files (e.g. <code>.dat, <code>.ixb) would be created in the ctrl directory.I guess nobody used this feature? It is pretty cool, but not really documented. If you were using it before this commit, you'll need to move your sub-directories data files to data/dirs or re-add the files (recreate the database files). And you can remove the old cruft from the ctrl dir.
    --- SBBSecho 3.12-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Ragnarok@1:103/705 to Rob Swindell on Thu Jan 21 13:51:51 2021
    El 21/1/21 a las 06:44, Rob Swindell escribi├│:
    https://gitlab.synchro.net/main/sbbs/-/commit/9439f5b8e23351f3a96982b0 Modified Files:
    src/sbbs3/load_cfg.c
    Log Message:
    Fix: initialize default data directories after auto-creating sub-dirs

    When a file library's "Access to Sub-directories" option was enabled, any
    auto-created directories would have their data dir initialized as "blank" (empty), so their data files (e.g. <code>.dat, <code>.ixb) would be created in the ctrl directory.

    I guess nobody used this feature? It is pretty cool, but not really
    documented. If you were using it before this commit, you'll need to move your sub-directories data files to data/dirs or re-add the files (recreate the database files). And you can remove the old cruft from the ctrl dir.
    ---
    ├╛ Synchronet ├╛ Vertrauen ├╛ Home of Synchronet ├╛
    [vert/cvs/bbs].synchro.net


    Coincidentally, a few weeks ago I found that option and could not find
    any documentation for it.

    When you have some free time, can you add some documentation please?

    Thank you!

    ---
    ■ Synchronet ■ Dock Sud BBS TLD 24 HS - bbs.docksud.com.ar
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Digital Man@1:103/705 to Ragnarok on Thu Jan 21 12:21:15 2021
    Re: Re: src/sbbs3/load_cfg.c
    By: Ragnarok to Rob Swindell on Thu Jan 21 2021 01:51 pm

    When you have some free time, can you add some documentation please?

    Yup, plan to.
    --
    digital man

    Rush quote #31:
    Live for yourself, there's no one else more worth living for
    Norco, CA WX: 67.9°F, 43.0% humidity, 7 mph NE wind, 0.00 inches rain/24hrs
    --- SBBSecho 3.12-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows)@1:103/705 to Git commit to main/sbbs/master on Mon Sep 25 16:36:18 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/566c41b6ab3cbbe97fc25009
    Modified Files:
    src/sbbs3/load_cfg.c
    Log Message:
    Allow text strings to be identified by number (instead of ID)

    for those that want to use cryptic numbers rather than human-readable names. --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows)@1:103/705 to Git commit to main/sbbs/master on Mon Sep 25 17:39:43 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/b44b6ea733cd12a51560b980
    Modified Files:
    src/sbbs3/load_cfg.c
    Log Message:
    Fix off-by-one issue in previous commit, text.dat string numbers are 1-based --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows 11)@1:103/705 to Git commit to main/sbbs/master on Mon Dec 18 21:48:11 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/4197ced7afc511120e8d284b
    Modified Files:
    src/sbbs3/load_cfg.c
    Log Message:
    Fix new crash on startup for Windows build

    load_cfg() calls free_cfg() before do_cryptInit() is called, so the ssl_rwlock was uninitialized here.
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows 11)@1:103/705 to Git commit to main/sbbs/master on Mon Dec 18 21:51:09 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/c15b7a2f57ccf21ad44f7e3c
    Modified Files:
    src/sbbs3/load_cfg.c
    Log Message:
    Fix new clang warning: incompatible pointer types passing 'long *' to parameter
    of type 'int *'
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Deucе@1:103/705 to Git commit to main/sbbs/master on Tue Dec 19 01:29:23 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/587eca57b14dc020487c22d8
    Modified Files:
    src/sbbs3/load_cfg.c
    Log Message:
    We don't need to set tls_certificate to -1 in prep_cfg() because
    it's only called from load_cfg() which has already set it to -1.

    We also don't need to check prepped twice to make sure it's extra true.
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows 11)@1:103/705 to Git commit to main/sbbs/master on Tue Dec 19 01:31:01 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/d47a2258d7f870e139cdf0b4
    Modified Files:
    src/sbbs3/load_cfg.c
    Log Message:
    Always set scfg.prepped to FALSE in free_cfg()

    Remove some redundant redundancies, redundantly
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows 11)@1:103/705 to Git commit to main/sbbs/master on Tue Jan 23 12:17:37 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/0503c2900a17ddd91986b312
    Modified Files:
    src/sbbs3/load_cfg.c
    Log Message:
    Fix uninitialized cfg.colors[] element usage caught by Deuce (and Clang?)

    Conditional jump or move depends on uninitialised value(s)
    at 0x4AE768D: sbbs_t::backfill(char const*, float, int, int) (con_out.cpp:1445)
    by 0x4AE7855: sbbs_t::progress(char const*, int, int, int) (con_out.cpp:1467)
    by 0x4AE91A9: ProgressLoadingMsgPtrs(void*, int, int) (data_ovl.cpp:27)
    by 0x4C7C577: getmsgptrs (userdat.c:3972)
    by 0x4AE9144: sbbs_t::getmsgptrs() (data_ovl.cpp:39)
    by 0x4BF9237: sbbs_t::logon() (logon.cpp:452)
    by 0x4AC1CE2: sbbs_t::answer() (answer.cpp:636)
    by 0x4C0FD37: node_thread(void*) (main.cpp:4277)

    Introduced in commit 48e7520e (when colors was converted from a byte array
    to a uint array), we weren't memsetting the right number of bytes.

    Since color is not an array of ints (not bytes), memset (of non-zero values) isn't really the right initialization approach anyway. Now using a for-loop. --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)