src/sbbs3 ftpsrvr.c 1.436 1.437
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv6525

Modified Files:
ftpsrvr.c
Log Message:
Check the return value of mkdir() to make Coverity happy and log an error if it's non-zero.

--- SBBSecho 3.03-Win32
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

src/sbbs3 ftpsrvr.c 1.438 1.439
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv5804

Modified Files:
ftpsrvr.c
Log Message:
Add AUTH, PBSZ, PROT, and CCC to HELP. Also, add CCC to FEAT



--- SBBSecho 3.03-Win32
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

src/sbbs3 ftpsrvr.c 1.439 1.440
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv6541

Modified Files:
ftpsrvr.c
Log Message:
CCC doesn't have a registered FEAT code.



--- SBBSecho 3.03-Win32
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

src/sbbs3 ftpsrvr.c 1.440 1.441
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv9696

Modified Files:
ftpsrvr.c
Log Message:
Add a comment regarding the unimplemented STAT command


--- SBBSecho 3.03-Win32
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

src/sbbs3 ftpsrvr.c 1.441 1.442
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv11760

Modified Files:
ftpsrvr.c
Log Message:
Don't write errors to the data socket when resp is false either.



--- SBBSecho 3.03-Win32
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

src/sbbs3 ftpsrvr.c 1.442 1.443
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv10074

Modified Files:
ftpsrvr.c
Log Message:
Initial MLST/MLSD support. Relative paths are terrible, but they're terrible in the other stuff too. The local mounts may not be at 100% either, but
the appear to work.



--- SBBSecho 3.03-Win32
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

src/sbbs3 ftpsrvr.c 1.443 1.444
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv29725

Modified Files:
ftpsrvr.c
Log Message:
Add support for UNIX.ownername to MLSx commands.
Add support for OPTS MLST command.
Fix MLST FEAT response.



--- SBBSecho 3.03-Win32
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

src/sbbs3 ftpsrvr.c 1.444 1.445
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv1412

Modified Files:
ftpsrvr.c
Log Message:
Fix relative paths by rewriting parsepath() from scratch.
LIST should likely check the return value now...


--- SBBSecho 3.03-Win32
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

src/sbbs3 ftpsrvr.c 1.445 1.446
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv3064

Modified Files:
ftpsrvr.c
Log Message:
Fix OPTS MLST support for local files
Add the '..' parent directory to libs and dirs
Fly the TVFS flag now that relative dirs are working



--- SBBSecho 3.03-Win32
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

src/sbbs3 ftpsrvr.c 1.446 1.447
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv5261

Modified Files:
ftpsrvr.c
Log Message:
Skip errored path components and return a root error... LIST really needs
to handle this somehow (but currently doesn't).
Also, remove some debug output.



--- SBBSecho 3.03-Win32
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

src/sbbs3 ftpsrvr.c 1.447 1.448
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv13000

Modified Files:
ftpsrvr.c
Log Message:
Return an empty LIST or NLST listing if parsepath() fails.


--- SBBSecho 3.03-Win32
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

src/sbbs3 ftpsrvr.c 1.448 1.449
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv423

Modified Files:
ftpsrvr.c
Log Message:
You need xpprintf.h for the vasprintf() prototype on Windows.

--- SBBSecho 3.03-Win32
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

src/sbbs3 ftpsrvr.c 1.449 1.450
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv5566

Modified Files:
ftpsrvr.c
Log Message:
Add support for ftpalias.cfg to parsepath(). Directory aliases now work
like symlinks... note that they aren't shown as symlinks in the directory output, so it may be a bit of a surprise when relative paths are relative
to the target rather than the alias.



--- SBBSecho 3.03-Win32
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

src/sbbs3 ftpsrvr.c 1.450 1.451
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv21303

Modified Files:
ftpsrvr.c
Log Message:
Fix format of modify fact.



--- SBBSecho 3.03-Win32
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

src/sbbs3 ftpsrvr.c 1.451 1.452
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv30592

Modified Files:
ftpsrvr.c
Log Message:
Add the unique fact to things that can have aliases in ftpalias.cfg
(dirs and files). Include the unique fact in aliases as well. Clients can
now tell that aliases are the same entry.

For MLST <dir>, always return the full path of the dir instead of the
specified or relative path.

Likely some other minor fixes as well.



--- SBBSecho 3.03-Win32
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

src/sbbs3 ftpsrvr.c 1.452 1.453
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv12036

Modified Files:
ftpsrvr.c
Log Message:
Map date uploaded to the created fact.



--- SBBSecho 3.03-Win32
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

src/sbbs3 ftpsrvr.c 1.453 1.454
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv28332

Modified Files:
ftpsrvr.c
Log Message:
Fix up load access with MLSx
Call FULLPATH() on local directories after changing
Add cdir to MLSD in the bbs: mount
Return full path in MLST



--- SBBSecho 3.03-Win32
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

src/sbbs3 ftpsrvr.c 1.455 1.456
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv20007

Modified Files:
ftpsrvr.c
Log Message:
Use crypt_ll() in the FTP server.



--- SBBSecho 3.03-Win32
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

src/sbbs3 ftpsrvr.c 1.457 1.458
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv18469

Modified Files:
ftpsrvr.c
Log Message:
Don't socket recv() errors for TLS sessions.


--- SBBSecho 3.03-Win32
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

src/sbbs3 ftpsrvr.c 1.458 1.459
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv4434

Modified Files:
ftpsrvr.c
Log Message:
Elminated the redundnat "XXX Server listening" log messages
(the multisock stuff already logs this for each interface and port).

--- SBBSecho 3.03-Win32
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

src/sbbs3 ftpsrvr.c 1.462 1.463
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv12049

Modified Files:
ftpsrvr.c
Log Message:
That was likely supposed to be a semi-colon.



--- SBBSecho 3.03-Win32
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

src/sbbs3 ftpsrvr.c 1.464 1.465
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv14790

Modified Files:
ftpsrvr.c
Log Message:
Fix infinite loop with TLS FTP control session.



--- SBBSecho 3.03-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

src/sbbs3 ftpsrvr.c 1.466 1.467
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv24592

Modified Files:
ftpsrvr.c
Log Message:
Initialize estr to NULL in start_tls(), likely cause of free() assert in Windows debug build.

--- SBBSecho 3.04-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

src/sbbs3 ftpsrvr.c 1.467 1.468
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv28101

Modified Files:
ftpsrvr.c
Log Message:
The real apparent fix for the free() assertion: use free_crypt_attrstr() instead

--- SBBSecho 3.04-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

src/sbbs3 ftpsrvr.c 1.468 1.469
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv23693

Modified Files:
ftpsrvr.c
Log Message:
Fix get_ssl_cert() failure log message (wrong number of arguments).
Put "TLS" in the failure log messages rather than repeating "FTP".

--- SBBSecho 3.04-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

src/sbbs3 ftpsrvr.c 1.469 1.470
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3

Modified Files:
ftpsrvr.c
Log Message:
Enable GCC-assisted printf-style format/arg checking for lprintf, sockprintf and send_mlsx().
Fix numerous printf-style argument bugs, many in the TLS and MLSx support.


--- SBBSecho 3.04-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

src/sbbs3 ftpsrvr.c 1.470 1.471
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv27658

Modified Files:
ftpsrvr.c
Log Message:
Bug-fix: The GCES macro already prints and *frees* the error string, so
you can't print and free it again after calling that macro.


--- SBBSecho 3.04-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

src/sbbs3 ftpsrvr.c 1.472 1.473
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv29765

Modified Files:
ftpsrvr.c
Log Message:
Log much more detail upon any file open errors in the ftp server.


--- SBBSecho 3.06-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

src/sbbs3 ftpsrvr.c 1.473 1.474
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv14091

Modified Files:
ftpsrvr.c
Log Message:
Added (or moved) user's name/alias to/in log output to be more consistent
with the terminal and mail servers' log output and provide more details
(e.g. on errors).


--- SBBSecho 3.06-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

src/sbbs3 ftpsrvr.c 1.474 1.475
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3

Modified Files:
ftpsrvr.c
Log Message:
GCC spotted a formatting error in the previous commit. Fixed.


--- SBBSecho 3.06-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

src/sbbs3 ftpsrvr.c 1.475 1.476
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv13941

Modified Files:
ftpsrvr.c
Log Message:
Don't wait for QWK packet creation if the server has been locally terminated. Double the duration to wait for client threads to terminate. Heck, this might should be an infinite wait since "bad things" happen if the client thread continues after a cleanup().


--- SBBSecho 3.06-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

src/sbbs3 ftpsrvr.c 1.476 1.477
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3

Modified Files:
ftpsrvr.c
Log Message:
Deal with some gcc reported printf-use warnings, mainly around 64-bit ints.


--- SBBSecho 3.06-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

src/sbbs3 ftpsrvr.c 1.477 1.478
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv21132

Modified Files:
ftpsrvr.c
Log Message:
Fix bug with filename aliases (in ftpalias.cfg) which caused an incompatility with Chrome (the browser). Chrome will attempt to "CWD" to a filename and if that filename was an alias from the ftpalias.cfg, we would return a
successful (213) response - erroneously. The code did appear to check for
this condition by calling ftpalias() with a NULL second (filename)
parameter, but that didn't actually work. The 'alias+1' check for a slash appears to have (always?) been clearly wrong as a prefixed slash is already skipped (in the requested path) before calling ftpalias().


--- SBBSecho 3.06-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

On 2018 Oct 31 00:31:28, you wrote to CVS commit:

src/sbbs3 ftpsrvr.c 1.477 1.478
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv21132

Modified Files:
ftpsrvr.c
Log Message:
Fix bug with filename aliases (in ftpalias.cfg) which caused an incompatility with Chrome (the browser). Chrome will attempt to "CWD" to a filename and if that filename was an alias from the ftpalias.cfg, we would return a successful (213) response - erroneously.

FWIW: this is how googlebot determines if the link is a file or a directory... they always try to CD to the given name and if that fails, they they do a get... this being via http(s) as well as ftp(s?)...

i appreciate this because it aids in a question that i asked on IRC about how to place files into the virtual '/' directory ;)

)\/(ark

Always Mount a Scratch Monkey
Do you manage your own servers? If you are not running an IDS/IPS yer doin' it wrong...
... Everything has already been said.
---
* Origin: (1:3634/12.73)

mark wrote:

On 2018 Oct 31 00:31:28, you wrote to CVS commit:

src/sbbs3 ftpsrvr.c 1.477 1.478
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv21132

Modified Files:
ftpsrvr.c
Log Message:
Fix bug with filename aliases (in ftpalias.cfg) which caused an
incompatility with Chrome (the browser). Chrome will attempt to "CWD" to a
filename and if that filename was an alias from the ftpalias.cfg, we would
return a successful (213) response - erroneously.

FWIW: this is how googlebot determines if the link is a file or a

directory...

they always try to CD to the given name and if that fails, they they do a get... this being via http(s) as well as ftp(s?)...

i appreciate this because it aids in a question that i asked on IRC about

how

to place files into the virtual '/' directory ;)

Yup, I asked DM how to do it and he suggested the ftpalias.cfg directory
but when I tried it there were problems when using Chrome, so we were able
to squish a bug at the same time.

---
■ Synchronet ■ End Of The Line BBS - endofthelinebbs.com
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

src/sbbs3 ftpsrvr.c 1.478 1.479
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv2867

Modified Files:
ftpsrvr.c
Log Message:
Fixed-up some log output messages:
- user alias was missing from some messages or in the wrong place
- added hostname and IP address to the "ILLEGAL FILENAME ATTEMPT" warnings


--- SBBSecho 3.06-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

src/sbbs3 ftpsrvr.c 1.479 1.480
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3

Modified Files:
ftpsrvr.c
Log Message:
Fix bug introduced in rev 1.478 which prevented aliased directories from
being CWD'd (chdir'd) into.
I resisted the temptation to convert ftpalias.cfg to a different (sane)
format (e.g. .ini) at this time, but that really should be done.
Oh, and I noticed that aliases don't work with "DIR" wildcards, so that's a
bug that needs fixing too.


--- SBBSecho 3.06-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

src/sbbs3 ftpsrvr.c 1.480 1.481
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv5133

Modified Files:
ftpsrvr.c
Log Message:
Fix a couple of problems introduced in the recent ftpalias() churn:
- a CWD attempt to a /alias/filename would report 'success' to the client
(Chrome web browser)
- the ftpalias.cfg file was left open in some instances


--- SBBSecho 3.06-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

src/sbbs3 ftpsrvr.c 1.481 1.482
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv27429

Modified Files:
ftpsrvr.c
Log Message:
Hackety-hack-hack... hack
So I tested the following cases, which all pass:
cwd diralias -> 250 CWD command successful.
cwd /diralias -> 250 CWD command successful.
cwd /diralias/ -> 250 CWD command successful.
cwd /diralias/filename -> 550 filename: No such directory.
cwd /filealias -> 550 filealias: No such diretory.
cwd /filealias/ -> 550 : No such diretory.
retr filealias -> 150 Opening BINARY mode data connection for file transfer. retr /filealias -> 150 Opening BINARY mode data connection for file transfer.

Hopefully is the end of the fixes for Chrome browser ftp weirdness
(tries to "CWD" to anything/everything to determine if it's a file or not).


--- SBBSecho 3.06-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

src/sbbs3 ftpsrvr.c 1.483 1.484
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv18830

Modified Files:
ftpsrvr.c
Log Message:
Log the currently logged-in user name along with any "!ERROR ... removing" error messages.


--- SBBSecho 3.06-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

src/sbbs3 ftpsrvr.c 1.484 1.485
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv2461

Modified Files:
ftpsrvr.c
Log Message:
Optimized all directory listings and index generation:
- use GLOB_MARK to eliminate calls to isdir() in loops
- use stat() rather than calls to flength() and fdate()
- don't call getfiledat() if getfileixb() failed
- profiling info-level log msgs added for index/listing generation, e.g.
"detailed listing (3459 bytes) of /main/SBBS (45 files) created in 2 seconds"

Fixed bug with indexes generated for directories with the
"Access Files Not In Database" option enabled, files not in database were excluded from the generated index (e.g. 00index, 00index.html).

--- SBBSecho 3.06-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

src/sbbs3 ftpsrvr.c 1.485 1.486
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv19961

Modified Files:
ftpsrvr.c
Log Message:
Fix some new issues due to use of GLOB_MARK:
getfname() on a path that ends in a slash, returns an empty string pointer. Fixed-up some logging output around listing creations.

--- SBBSecho 3.06-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

src/sbbs3 ftpsrvr.c 1.486 1.487
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv3268

Modified Files:
ftpsrvr.c
Log Message:
Further optimization for directory index and listing generation: if "Check for File Existence" is disabled (in SCFG->File Areas... Toggle Options), then don't check the disk for the file's existence, size, or date/time.

--- SBBSecho 3.06-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

src/sbbs3 ftpsrvr.c 1.489 1.490
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv10196

Modified Files:
ftpsrvr.c
Log Message:
Fix crash introduced in 1.485.

When the command is MLST, fp is NULL, so should not be passed to ftell().


--- SBBSecho 3.07-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

src/sbbs3 ftpsrvr.c 1.490 1.491
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv25642

Modified Files:
ftpsrvr.c
Log Message:
Fix bug where Synchronet FTP Server %s-%s Ready message did not have a
reply code. Maybe this used to be on the same line as the BBS name?



--- SBBSecho 3.07-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

Re: src/sbbs3/ftpsrvr.c
By: deuce to CVS commit on Thu May 30 2019 08:31 pm

src/sbbs3 ftpsrvr.c 1.490 1.491
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv25642

Modified Files:
ftpsrvr.c
Log Message:
Fix bug where Synchronet FTP Server %s-%s Ready message did not have a
reply code. Maybe this used to be on the same line as the BBS name?

No, I think you're misreading the FTP spec (RFC959):
Thus the format for multi-line replies is that the first line
will begin with the exact required reply code, followed
immediately by a Hyphen, "-" (also known as Minus), followed by
text. The last line will begin with the same code, followed
immediately by Space <SP>, optionally some text, and the Telnet
end-of-line code.

digital man

Synchronet/BBS Terminology Definition #12:
CBM = Commodore Business Machines
Norco, CA WX: 55.6°F, 95.0% humidity, 2 mph ESE wind, 0.00 inches rain/24hrs --- SBBSecho 3.07-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

src/sbbs3 ftpsrvr.c 1.491 1.492
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv28963

Modified Files:
ftpsrvr.c
Log Message:
Revert previous change. NetLogger has the bug, not Synchronet.



--- SBBSecho 3.07-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

src/sbbs3 ftpsrvr.c 1.497 1.498
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv1115

Modified Files:
ftpsrvr.c
Log Message:
Increase the size of the buffer used to format the download notification short messages (telegrams) from 128 to 256 bytes to resolve observed truncation of download notification messages like this:
"Guns N Roses - Hotel Brawl Jam (Live).mp3 was FTP-downloaded by Guest [89.245.6.
199]
You were awarded 2,057,356 cred"

--- SBBSecho 3.10-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

src/sbbs3 ftpsrvr.c 1.498 1.499
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv30088

Modified Files:
ftpsrvr.c
Log Message:
Log the user name or IP address in more places.

--- SBBSecho 3.11-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

src/sbbs3 ftpsrvr.c 1.500 1.501
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv23645

Modified Files:
ftpsrvr.c
Log Message:
More file existence/length checks, with only a WARNING log level (not error) since some QWKnet nodes apparently like to start concurrent QWK packet downloads and inevitably one finishes first, deleting the file, and the second transfer logs and error. Examples:
8/14 08:10:06p 2296 <EPHRAM> downloading QWK packet (1320 bytes) in passive
mode
8/14 08:10:06p 3792 <EPHRAM> downloading QWK packet (1320 bytes) in passive
mode
8/14 08:10:06p 2296 <EPHRAM> DATA Transfer successful: 1320 bytes sent in 0
seconds (2640 cps)
8/14 08:10:06p 3792 <EPHRAM> !DATA ERROR 2 (No such file or directory) line
1376 opening s:\sbbs\data\file/0888.qwk
8/14 11:28:55p 2576 <POTOGOLD> downloading QWK packet (27129 bytes) in passive mode
8/14 11:28:55p 2576 <POTOGOLD> DATA Transfer successful: 27129 bytes sent in 0 seconds (54258 cps)
8/14 11:28:55p 1924 <POTOGOLD> downloading QWK packet (4294967295 bytes) in
passive mode
8/14 11:28:56p 1924 <POTOGOLD> !DATA ERROR 2 (No such file or directory) line 1376 opening s:\sbbs\data\file/0168.qwk

Also some more 64-bit file length support (flength returns an off_t now, not a ulong).
And ftell() returns a long (not a ulong).


--- SBBSecho 3.11-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/sbbs/sbbs/-/commit/10477fe29378aebb82b8efd2
Modified Files:
src/sbbs3/ftpsrvr.c
Log Message:
Create the pack*.now with fmutex() to prevent simultaneous QWK packsProbably only a problem on Vertrauen, but some QWKnet nodes, for some unknown reason, like to FTP-connect multiple times concurrently and request to download a QWK packet. This creates a race condition where the QWK packet gets created/downloaded/deleted before the second FTP connection can successfully download the same file, thus logging an error "opening file " on the server (VERT). So if the pack*.now file already exists, reject the download request. "What are doing?" is what I really want to ask these nodes, but better just throw them an error response and quietly move on.
--- SBBSecho 3.11-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/commit/31d07482c7dc81b1af72e495
Modified Files:
src/sbbs3/ftpsrvr.c
Log Message:
Remove 3 second delay before disconnecting when max clients reachedThis seems to be misguided and would only increase the chances of a DoS-type attack on TCP
session resources.A second 3-second delay upon malloc failure is also removed. --- SBBSecho 3.12-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/commit/dcb003099daa5b03e53542d4
Modified Files:
src/sbbs3/ftpsrvr.c
Log Message:
Log messages indicating AUTH TLS success or failure and set client protSet the client protocol to "FTPS" upon successful TLS startup in the control connection
(response to the AUTH TLS command from the client). Log some messages indicating FTPS was attempted or successful.
--- SBBSecho 3.12-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/commit/3ead8a4d227af07c81c2c8e5
Modified Files:
src/sbbs3/ftpsrvr.c
Log Message:
Don't delete pack####.now upon FTP-logoffWhen a user logins to the FTP server concurrently, this creates arace condition with an/the other FTP session that may be creating/downloading a QWK packet. On Vertrauen, this results in theoccasional error removing the file since it was removed unexpectedly:!ERROR 2 (No such file or directory) in main.cpp line 2747 (event_thread) removing "/sbbs/data/pack1111.now" access=0
--- SBBSecho 3.12-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/commit/59b8829a0915a454233ea17d
Modified Files:
src/sbbs3/ftpsrvr.c
Log Message:
Fix CIDs 174500 and 174471
--- SBBSecho 3.12-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/commit/b62505add30804e8c6a6fb79
Modified Files:
src/sbbs3/ftpsrvr.c
Log Message:
Remove extraneous (void) typedefsSee if this resolves rjwboys reported error:threadwrap.h:204:42: error: expected expression before ΓÇÿdoΓÇÖ #define protected_uint32_init(pval, val) atomic_init(pval, val)
--- SBBSecho 3.13-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/commit/6fee19566f510a9c5cda36a4
Modified Files:
src/sbbs3/ftpsrvr.c
Log Message:
Detect TLS startup errors correct/fullyWe can't (apparently) only rely on the return value of start_tls(), we have to check the value of the crypt session too.This fix the possibility of this happening:Jun 7 18:07:26 sbbs synchronet:
ftp 0058 TLS ERROR 'No permiss.to perform this operation' (-21) opening keysetJun 7 18:07:26 sbbs synchronet: ftp 0058 <192.168.1.25> initialized TLS
successfullyInstead, we'll detect the failure and disable FTPS support, logging
"failed to initialize TLS successfully".
--- SBBSecho 3.14-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/commit/bb1ee45982174c3a0a73ce1e
Modified Files:
src/sbbs3/ftpsrvr.c
Log Message:
Fix segfault reported with ftpalias.cfg support in some casesftpalias() can return true even when the directory is not set to a validdirectory index (i.e. set to -1), so using as an array index would definitelysegfault. Part of commit
8ad30b6c by Deuce 3 years ago.I didn't test this as I'm not sure exactly the combination of ftpalias.cfgcontent and FTP command received that would trigger this, but it's mostdefinitely a bug.So should fix the segfault reported in issue #288.
--- SBBSecho 3.14-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/commit/15906e19c9b0b832027ce673
Modified Files:
src/sbbs3/ftpsrvr.c
Log Message:
Handle FTP requests for paths that start with "/./"Midnight Commander (mc) apparently sends requests like this for files(e.g. aliases) in the virtual root
directory.Fixes another part of the reported issue #288.
--- SBBSecho 3.14-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/commit/17a67ee9d95051145677ec52
Modified Files:
src/sbbs3/ftpsrvr.c
Log Message:
Fix FTPS upload failure: !DATA ERROR 0 receiving on data socketDon't treat CRYPT_ERROR_COMPLETE (-24) as a socket error during upload since it's an indication that the remote closed the connection and is the normal "end of file/transfer" indicator, not an error. 'rd' is already 0 in this case, so no need to set at all (since recv() returns 0 upon disconnect and that's what we're emulating here).Fixes issue #309 reported by Jas Hud.
--- SBBSecho 3.14-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

Re: src/sbbs3/ftpsrvr.c
By: Rob Swindell to Git commit to main/sbbs/master on Sun Dec 05 2021 06:42 pm

https://gitlab.synchro.net/main/sbbs/-/commit/17a67ee9d95051145677ec52 Modified Files:
src/sbbs3/ftpsrvr.c
Log Message:
Fix FTPS upload failure: !DATA ERROR 0 receiving on data socket

Don't treat CRYPT_ERROR_COMPLETE (-24) as a socket error during upload since it's an indication that the remote closed the connection and is the normal "end of file/transfer" indicator, not an error. 'rd' is already 0 in this case, so no need to set at all (since recv() returns 0 upon disconnect and that's what we're emulating here).

Fixes issue #309 reported by Jas Hud.

i cant upload files using any protocol on your bbs and cvs.synchro.net
---
■ Synchronet ■ ::: BBSES.info - free BBS services :::
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

Re: src/sbbs3/ftpsrvr.c
By: MRO to Rob Swindell on Mon Dec 06 2021 01:35 pm

Fixes issue #309 reported by Jas Hud.

i cant upload files using any protocol on your bbs and cvs.synchro.net

Working for me (now). I replied to your emails about this already. I appreciate
your continued testing.

Don't try to use SyncTERM v1.2b for uploads (they don't work).
--
digital man (rob)

Synchronet/BBS Terminology Definition #14:
CGA = Color Graphics Adapter (IBM)
Norco, CA WX: 72.0°F, 35.0% humidity, 8 mph NNW wind, 0.00 inches rain/24hrs --- SBBSecho 3.14-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

Re: src/sbbs3/ftpsrvr.c
By: Digital Man to MRO on Mon Dec 06 2021 01:20 pm

Re: src/sbbs3/ftpsrvr.c
By: MRO to Rob Swindell on Mon Dec 06 2021 01:35 pm

Fixes issue #309 reported by Jas Hud.

i cant upload files using any protocol on your bbs and cvs.synchro.net

Working for me (now). I replied to your emails about this already. I appreciate your continued testing.

Don't try to use SyncTERM v1.2b for uploads (they don't work).

yeah i tried to delete this msg but it already sent.
i'm using 1.1b win32 of syncterm
---
■ Synchronet ■ ::: BBSES.info - free BBS services :::
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

Re: src/sbbs3/ftpsrvr.c
By: MRO to Digital Man on Tue Dec 07 2021 02:58 pm

Re: src/sbbs3/ftpsrvr.c
By: Digital Man to MRO on Mon Dec 06 2021 01:20 pm

Re: src/sbbs3/ftpsrvr.c
By: MRO to Rob Swindell on Mon Dec 06 2021 01:35 pm

Fixes issue #309 reported by Jas Hud.

i cant upload files using any protocol on your bbs and cvs.synchro.net

Working for me (now). I replied to your emails about this already. I appreciate your continued testing.

Don't try to use SyncTERM v1.2b for uploads (they don't work).

yeah i tried to delete this msg but it already sent.
i'm using 1.1b win32 of syncterm

1.1 was released over a year ago. That's the supported/known-working version. 1.1b (for SyncTERM) means "beta" or pre-1.1.
--
digital man (rob)

This Is Spinal Tap quote #39:
Female Airport Security Officer: Do you have any artificial plates or limbs? Norco, CA WX: 54.1°F, 85.0% humidity, 0 mph SSW wind, 0.00 inches rain/24hrs --- SBBSecho 3.14-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

Re: src/sbbs3/ftpsrvr.c
By: Digital Man to MRO on Tue Dec 07 2021 07:45 pm

yeah i tried to delete this msg but it already sent.
i'm using 1.1b win32 of syncterm

1.1 was released over a year ago. That's the supported/known-working version. 1.1b (for SyncTERM) means "beta" or pre-1.1.

yeah, it works for what i use it for so i'm not going to upgrade.
it's not bombing out on me during connections.
---
■ Synchronet ■ ::: BBSES.info - free BBS services :::
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/commit/7ccc618a991a97d22336fcc0
Modified Files:
src/sbbs3/ftpsrvr.c
Log Message:
Log unallowed/illegal filenames in quotesPrefixed or trailing white-space characters would be hard to discern without this.
--- SBBSecho 3.14-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/commit/658773d65b44452a84a696fb
Modified Files:
src/sbbs3/ftpsrvr.c
Log Message:
Log the full path for rejected uploads based on directoryThe logged error "!attempted to upload to invalid directory" did log the actual path that was attempted to be uploaded.Added some quotes around other logged paths.
--- SBBSecho 3.14-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/commit/52b2e20a5dd8330adb315d73
Modified Files:
src/sbbs3/ftpsrvr.c
Log Message:
Change "attempted to upload to invalid directory" msgMake it more accurate/clear:"attempted to upload invalid path/filename"
--- SBBSecho 3.14-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/commit/5fdf8f0fddbcc5016c033af8
Modified Files:
src/sbbs3/ftpsrvr.c
Log Message:
Don't MQTT-publish the download of temp files
--- SBBSecho 3.20-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/commit/8e94a448a7346a36d4a85dbe
Modified Files:
src/sbbs3/ftpsrvr.c
Log Message:
Fix uploader-notification, credit awards, download-counters in FTP downloadsSince v3.19 (the new filebases), when a user FTP-downloaded a file, we
failedto properly find/load that file's record from the filebase (searching for
thefile's full path, rather than just the filename), so the code the incrementsthe file's download counter, notifies the uploader, awards credits, etc. didnot ever execute. This means that FTP-downloads for all files downloaded viaFTP were effectively "free" (and nobody noticed). No error was logged either.I discovered this while debugging the case of "(null)" filenames in theaction/download MQTT topic messages being published by the FTP server. Sothat issue is fixed as part of this commit as well.Oh, and if this code had executed before, it would have memory-leaked thefile information, so that's fixed too (added call to smb_freefilemem). Ugh.
--- SBBSecho 3.20-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/commit/3709ae9d438cc0932f70c46f
Modified Files:
src/sbbs3/ftpsrvr.c
Log Message:
Free/zero out the file_t struct *after* sending the MQTT action msg... not before. This explains why FTP-uploaded actions had a (null) filename.
--- SBBSecho 3.20-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/commit/448e18156d14b0b8a2bb535a
Modified Files:
src/sbbs3/ftpsrvr.c
Log Message:
Add free disk space check against minimum space configuredDisallow uploads when
free disk space falls below minimum configuredminimum free disk space.This fixes issue #535
--- SBBSecho 3.20-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/commit/36fea1c5acf774be516d1df6
Modified Files:
src/sbbs3/ftpsrvr.c
Log Message:
Limit uploaded file sizes, accounting for free disk spaceThe lower of the configured maximum file size (for the FTP server) andthe available disk space minus the configured minimum free disk spaceis used as the maximum file size to
allow upload. Appended filesare accounted for too.
--- SBBSecho 3.20-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/commit/2e93426824b48954395c0b1f
Modified Files:
src/sbbs3/ftpsrvr.c
Log Message:
Fix some signed/unsigned comparison warnings from MSVC
--- SBBSecho 3.20-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/commit/3e2c3176de6108c697d25a69
Modified Files:
src/sbbs3/ftpsrvr.c
Log Message:
Fix false "SUSPECTED BOUNCE ATTACK ATTEMPT" for IPv6 FTP-data connectionsThis bug only impacted non-passive FTP connections. Using an FTP clientwith active (not passive) data connections over an IPv6 connection wouldfalse-trigger the "bounce attack" detection and the FTP server responded with"504 Bad port number" and logged a hack attempt in data/hack.log.The issue was that we were comparing the socket address structure (whichcontains other fields besides the address itself) between the control andproposed-data connections. While this logic worked okay for IPv4,it did not for IPv6 (the 2 structs contained some non-address differences).Rather than modify the socket address structures to match where needed, I'mjust comparing the string representation of the addresses, since that'swhat we really care about anyway.Thank to "mark i" of Truck Stop BBS for alerting me to this issue
--- SBBSecho 3.20-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/commit/5d903235ca2629f59dc78999
Modified Files:
src/sbbs3/ftpsrvr.c
Log Message:
Log errno description upon QWK pack mutex file creation failure
--- SBBSecho 3.20-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/commit/339599be4e8c05ed8e3fabe9
Modified Files:
src/sbbs3/ftpsrvr.c
Log Message:
Fix MSLT and MSLD response for QWK packet filename in root directory

Reusing the variable 'str' here for multiple purposes meant the QWK packet filename was overwritten by the owner name (the system's BBS-ID):

mlsd

229 Entering Extended Passive Mode (|||2001|)
150 Opening ASCII mode data connection for MLSD.
Type=file;Perm=r;UNIX.ownername=VERT; 00index
Type=cdir;Perm=elc;UNIX.ownername=VERT; /
Type=file;Perm=r;UNIX.ownername=VERT; VERT

That last file there should have been "VERT.qwk"
--- SBBSecho 3.20-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/commit/3a25ed550b4f5d6563da0d8a
Modified Files:
src/sbbs3/ftpsrvr.c
Log Message:
Use safe string copying in get_owner_name() via strlcpy()
--- SBBSecho 3.20-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/commit/bb4ccdaad2c07262560ddab9
Modified Files:
src/sbbs3/ftpsrvr.c
Log Message:
Restore ftpalias.cfg support for MLSx commands

Support was accidentally removed as part of commit 0d01544d, meaning
the ftpalias.cfg wasn't used at all in responses to the MLSx commands as reported by Max (WESTLINE) using Total Commander, FileZilla and Directory
opus. The traditional "LIST" commands still worked fine with ftpalias.cfg contents just fine.

The reason this code was accidentally removed was due to the errant
copy/pasted comparison with startup->html_index_file that did not belong here and made the block appear related to HTML index file generation. It was not. This was just a bug in the initial implementation of MLSx support in
commit d4deb4b3.

Also included in this commit:
- Return the date/size of the user's QWK packet file, if it exists, in MLSx
response.
- send_mlsx_entry() won't report negative time_t values as file modify dates
(flength returns -1 upon failure/file-not-found).
- get_owner_name() returns the string, making it easier to use in function
calls.

There appears to still be some work to do to make the MLSx commands fully compliant with RFC 3659 (e.g. "mlst filename" from ftpalias.cfg should work
but does not), but at least FileZilla displays ftpalias.cfg files and directories correctly now.
--- SBBSecho 3.20-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/commit/e1b0164230ba4987cae0c3df
Modified Files:
src/sbbs3/ftpsrvr.c
Log Message:
Mostly time_t printfs, but also an odd bit where it's printing a
value that's not an off_t as one.
--- SBBSecho 3.20-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/commit/0ca7156dc5215b928bf5a689
Modified Files:
src/sbbs3/ftpsrvr.c
Log Message:
Reduce log severity of QWK-packet removal error log message to WARNING

This allows each call to ftp_remote() to specify the log level for any remove failure. All others file-removal failures will continue to log at ERROR level.

I get this particular (harmless) error a lot, so just reducing to warning:
ftp ... !ERROR 13 (Permission denied) (line 860) removing file: path/to/*.qwk --- SBBSecho 3.20-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/commit/05420809878c8fd7f272fa87
Modified Files:
src/sbbs3/ftpsrvr.c
Log Message:
ftp_remove() returns a bool (not an int) now, so do the right thing
--- SBBSecho 3.20-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)