1. Forum
  2. DOVE-Net
  3. Synchronet Programming

  • src/sbbs3/getkey.cpp

    From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Wed Nov 22 15:30:20 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/94fe4232d00189c225b4fd1e
    Modified Files:
    src/sbbs3/getkey.cpp
    Log Message:
    Fix CID 469138

    getkeys() is actually never (currently) called with a NULL arg, so this
    could not actually occur, but better to prepare for that eventuality.

    This looks like a case of not following the YAGNI principle.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sat Aug 3 19:58:06 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/6cbc54eb7026741e89ede75f
    Modified Files:
    src/sbbs3/getkey.cpp
    Log Message:
    Better support for a blank ("") text.dat AreYouThere string

    If a sysop doesn't want this warning to do anything, then no need to save
    and restore the current (last displayed) line of text.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Tue Oct 22 22:13:17 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/cd144bbe616fa7e325898068
    Modified Files:
    src/sbbs3/getkey.cpp
    Log Message:
    Expand tildes in mnemonics strings that conain non-attr Ctrl-A codes

    Fix for issue #800

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sun Dec 22 00:50:13 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/e0931d6dc261335a14e6b54c
    Modified Files:
    src/sbbs3/getkey.cpp
    Log Message:
    Fix issue when receiving node messages while using down-arrow at pause prompt

    Hitting down-arrow key at a pause prompt normally displaye just one more line of the display text/file, but if you received a node message/telegram/notice after hitting down arrow, you'd get a screen full of text instead of just a single (one more) line, as you wanted.

    This looks to be because of the anti-recursive protection implemented in pause() - when it calls nodesync() after the key press, that displays
    node/user messages (if there are any) and if pause is called as a result
    (e.g. because the line counter was already set to cause a pause after the
    next line of output), it'd do nothing since that would be recursive. The fix
    is to simply set the line counter as a result of the down-arrow key press *after* the call to nodesync(), which might display multiple lines, but I
    think that's fine.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net