https://gitlab.synchro.net/main/sbbs/-/commit/edf9bc341b88832d376973d7
Modified Files:
src/xpdev/filewrap.h
Log Message:
_chsize_s() is only available in MSVC, apparently

Fixes Borland and mingw-GCC builds.

---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/c2291604b9b9a678e79167a4
Modified Files:
src/xpdev/filewrap.h
Log Message:
Fix runtime errors when built with UBSan

nopen.c:37:15: runtime error: left shift of 1 by 31 places cannot be
represented in type 'int'
nopen.c:39:18: runtime error: left shift of 1 by 31 places cannot be
represented in type 'int'
userdat.c:251:111: runtime error: left shift of 1 by 31 places cannot be
represented in type 'int'

There are lot of 1<<31 macro definitions in this repo, so I'm expecting a
lot more of this type of fix to be required to make UBSan happy.

---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/07a0cc3e2cbf6b4537a242ac
Modified Files:
src/xpdev/filewrap.h
Log Message:
Add FCLOSE_OPEN_FILE to close a FILE*, if it's open (non-NULL), and NULLify it

Change CLOSE_OPEN_FILE to a do/while(0) to eliminate extraneous semicolon

---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/ac9c138a8e5158192868bf56
Modified Files:
src/xpdev/filewrap.h
Log Message:
Add FILE_RETRY_ERRNO() definition, to be used in sopen()/lock() loops

Note: EBUSY was added to the list of errno values that should cause a retry
as observed on Vertrauen, running sbbs-linux on a Samba mount, opening
locked files can return failure (-1) with errno = EBUSY, e.g.
evnt BBS Events !ERROR 16 (Device or resource busy) in logon.cpp line 616 (logonstats) reading "system stats" access=0

This was apparently resolved by adding EBUSY (16) the values that trigger an sopen()
retry (i.e. from [f]nopen()).

---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/8f79b2099df41e212ef2030f
Modified Files:
src/xpdev/filewrap.h
Log Message:
Retry file lock/read operations on EIO errors

As seen on MacOS, an SMB shared file can cause the Mac SMB client to report EIO error on locked-file read or lock attempts. So retry.

---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/fa4a57955f422dbf698bd561
Modified Files:
src/xpdev/filewrap.h
Log Message:
Resolve Borland build warning: missing xp_lockfile() prototype

---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net